This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Fix: Kanbanize service fails for :issues and :issue_comment events #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Should you be testing both of these in a separate test? One for the push event and one for the issue event?
Contributor
Author
There was a problem hiding this comment.
I created two tests because the cases are different.
For the push case, we check that when a branch filter is applied the test will pass for the provided repo ref.
For the issue event we don't provide a "ref" property in the payload(which was the reason the service was failing) and I check this in a separate test case.
kdaigle
added a commit
that referenced
this pull request
Feb 4, 2015
Fix: Kanbanize service fails for :issues and :issue_comment events
Member
|
Thanks! 🍰 This will go out later today. |
Contributor
Author
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch filtering logic depends on the 'ref' property of the payload.
:issues and :issue_comment events do not have such a property and the service was failing.