Please read the contributing.md in the repo and follow the guidelines. Your
service is inheriting from the wrong class.

On Thursday, November 14, 2013, SkyDeskProjects wrote:

Request for GitHub integration with SkyDesk Projects.

You can merge this Pull Request by running

git pull https://github.com/SkyDeskProjects/github-services master

Or view, comment on, or merge it at:

#732
Commit Summary

• Create skydeskprojects
• Create skydeskprojects.rb
• Create skydeskprojects_test .rb
• Update skydeskprojects

File Changes

• A docs/skydeskprojectshttps://github.com/Request for GitHub integration with SkyDesk Projects. #732/files#diff-0(19)
• A lib/services/skydeskprojects.rbhttps://github.com/Request for GitHub integration with SkyDesk Projects. #732/files#diff-1(15)
• A test/skydeskprojects_test .rbhttps://github.com/Request for GitHub integration with SkyDesk Projects. #732/files#diff-2(34)

Patch Links:

• https://github.com/github/github-services/pull/732.patch
• https://github.com/github/github-services/pull/732.diff

can you please give more details.

https://github.com/github/github-services/blob/master/CONTRIBUTING.md#contributing

Specifically the part where it says "Good Example" and "Bad Example".

Dear Corey,

This below is the service class. Should this be changed as per ""Good Example" Symperium. We don't know what has to be changed exactly and any help can be appreciated. Whether this is the class that should be modified or any other file, please let us know.

class Service::ZohoProjects < Service
string :project_id, :token
white_list :project_id

def receive_push
res = http_post "https://projects.skydesk.jp/serviceHook",
:pId => data['project_id'],
:authtoken => data['token'],
:scope => "projectsapi",
:payload => generate_json(payload)
if res.status != 200
raise_config_error
end
end
end

Thanks & Regards,
SkyDesk Team

---- On Thu, 14 Nov 2013 18:54:44 +0900 Corey Donohoe <[email protected]> wrote ----

https://github.com/github/github-services/blob/master/CONTRIBUTING.md#contributing
Specifically the part where it says "Good Example" and "Bad Example".
—
Reply to this email directly or view it on GitHub.

Yup, change it as per the simperium hook.

Specifically you should change your endpoint to take the raw payload as an http POST using the deliver method like this.

https://github.com/github/github-services/blob/master/lib/services/simperium.rb#L20-L41

We're starting to consolidate around this specific payload and it's worth building your integration to work with it rather than having to rewrite it in the future if we move exclusively to the new payload.

SkyDesk Projects is a Re-branded version of Zoho Projects . So, we are using the same service (ZohoProjects) with our own client.

Updated the Service name from ZohoProjects to SkyDeskProjects.

Hi Corey,
We have modified the skydeskprojects.rb file as per the simperium hook.
Can you please look into that and let us know if any further clarification is required . We have other dependency on GitHub ,which we can take up only after receiving the merge approval.
This is a high priority task for us.Any help would be appreciated.

Thanks,
SkyDeskProjects

---- On Tue, 19 Nov 2013 05:15:43 +0900 Corey Donohoe<[email protected]> wrote ----

Yup, change it as per the simperium hook.
Specifically you should change your endpoint to take the raw payload as an http POST using the deliver method like this.
https://github.com/github/github-services/blob/master/lib/services/simperium.rb#L20-L41
We're starting to consolidate around this specific payload and it's worth building your integration to work with it rather than having to rewrite it in the future if we move exclusively to the new payload.
—
Reply to this email directly or view it on GitHub.

I created a PR with your stuff but the tests are still failing.

  1) Failure:
test_push(SkyDeskProjectsTest) [/var/lib/jenkins/workspace/github-services-a53dca0c61c9/test/skydeskprojects_test.rb:20]:
<"1234"> expected but was
<nil>.

645 tests, 1837 assertions, 1 failures, 0 errors, 0 skips
rake aborted!

Hi Corey,
I have modified the changes and committed the files.Can you please re run the test and let me know the status?

Thanks,
SkyDeskProjects

Please try running the script/cibuild script or run bundle exec ruby test/skydeskprojects_test .rb. The code doesn't work.

Hi Corey,
Thanks for running the tests .We have fixed the issues and it is working fine in our local setup .Can you please test it and let us know ?

Thanks,
SkyDeskProjects

@SkyDeskProjects it looks like you still have a failing test:

  1) Failure:
test_push(SkyDeskProjectsTest) [/Users/kdaigle/github/github-services/test/skydeskprojects_test.rb:18]:
<"1234"> expected but was
<nil>.

Please fix that and let us know. Thanks!

Hi Kdaigle ,
we have tested the script in our local set up and it is working .Can you please check it again.