fix: guarantee order of load events #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelpuyol
reviewed
Mar 9, 2021
manuelpuyol
reviewed
Mar 10, 2021
manuelpuyol
approved these changes
Mar 11, 2021
koddsson
approved these changes
Mar 12, 2021
Comment on lines
+24
to
27
| // Functional stand in for the W3 spec "queue a task" paradigm | ||
| function task(): Promise<void> { | ||
| return new Promise(resolve => setTimeout(resolve, 0)) | ||
| } |
Comment on lines
+150
to
+153
| // We mimic the same event order as <img>, including the spec | ||
| // which states events must be dispatched after "queue a task". | ||
| // https://www.w3.org/TR/html52/semantics-embedded-content.html#the-img-element | ||
| return task() |
There was a problem hiding this comment.
This is really clear now.
test/test.js
Outdated
Comment on lines
449
to
456
| // Emulate some kind of timer clamping | ||
| const originalSetTimeout = window.setTimeout | ||
| let i = 60 | ||
| window.setTimeout = (fn, ms, ...rest) => originalSetTimeout.call(window, fn, ms + (i -= 20), ...rest) | ||
|
|
||
| document.body.appendChild(elem) | ||
| return Promise.all(events).then(() => { | ||
| window.setTimeout = originalSetTimeout |
There was a problem hiding this comment.
Can we move the timer clamping emulation and restoration into before and after hooks so that we don't end up with an emulated setTimeout if the tests fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
This refactors
fireto return a Promise, so that we can determine when an event has been fired (as we're not firing event synchronously).The test is pretty contrived and implementation dependant, but it red-greens consistently and race condition tests are hard to otherwise verify 🤷