Merge pull request #15 from github/esm-import-extensions

dgreif · web-flow · commit 699741d90a53 · 2022-01-26T06:55:07.000-07:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -4,7 +4,8 @@
   "extends": ["plugin:github/recommended", "plugin:github/typescript", "plugin:github/browser"],
   "rules": {
     "no-invalid-this": "off",
-    "@typescript-eslint/no-invalid-this": ["error"]
+    "@typescript-eslint/no-invalid-this": ["error"],
+    "import/extensions": ["error", "always"]
   },
   "overrides": [
     {
diff --git a/src/html.ts b/src/html.ts
@@ -5,8 +5,8 @@ import {
   processPropertyIdentity,
   processBooleanAttribute
 } from '@github/template-parts'
-import {processDirective} from './directive'
-import {processEvent} from './events'
+import {processDirective} from './directive.js'
+import {processEvent} from './events.js'
 import type {TemplatePart, TemplateTypeInit} from '@github/template-parts'
 
 function processSubTemplate(part: TemplatePart, value: unknown): boolean {
diff --git a/src/index.ts b/src/index.ts
@@ -1,4 +1,4 @@
-export {TemplateResult, html, render} from './html'
-export {isDirective, directive} from './directive'
-export {until} from './until'
-export {unsafeHTML} from './unsafe-html'
+export {TemplateResult, html, render} from './html.js'
+export {isDirective, directive} from './directive.js'
+export {until} from './until.js'
+export {unsafeHTML} from './unsafe-html.js'
diff --git a/src/unsafe-html.ts b/src/unsafe-html.ts
@@ -1,4 +1,4 @@
-import {directive} from './directive'
+import {directive} from './directive.js'
 import {NodeTemplatePart} from '@github/template-parts'
 import type {TemplatePart} from '@github/template-parts'
 
diff --git a/src/until.ts b/src/until.ts
@@ -1,5 +1,5 @@
-import {processPart} from './html'
-import {directive} from './directive'
+import {processPart} from './html.js'
+import {directive} from './directive.js'
 import type {TemplatePart} from '@github/template-parts'
 
 const untils: WeakMap<TemplatePart, {i: number}> = new WeakMap()
diff --git a/test/html.ts b/test/html.ts
@@ -1,4 +1,4 @@
-import {html, render, directive} from '..'
+import {html, render, directive} from '../lib/index.js'
 
 describe('html', () => {
   it('creates new TemplateResults with each call', () => {
diff --git a/test/unsafe-html.ts b/test/unsafe-html.ts
@@ -1,4 +1,4 @@
-import {html, render, unsafeHTML} from '..'
+import {html, render, unsafeHTML} from '../lib/index.js'
 
 describe('unsafeHTML', () => {
   it('renders basic text', async () => {
diff --git a/test/until.ts b/test/until.ts
@@ -1,4 +1,4 @@
-import {html, render, until} from '..'
+import {html, render, until} from '../lib/index.js'
 
 describe('until', () => {
   it('renders a Promise when it resolves', async () => {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import {directive} from './directive'`
	`1`	`+import {directive} from './directive.js'`
`2`	`2`	`import {NodeTemplatePart} from '@github/template-parts'`
`3`	`3`	`import type {TemplatePart} from '@github/template-parts'`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import {html, render, directive} from '..'`
	`1`	`+import {html, render, directive} from '../lib/index.js'`
`2`	`2`
`3`	`3`	`describe('html', () => {`
`4`	`4`	`it('creates new TemplateResults with each call', () => {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import {html, render, unsafeHTML} from '..'`
	`1`	`+import {html, render, unsafeHTML} from '../lib/index.js'`
`2`	`2`
`3`	`3`	`describe('unsafeHTML', () => {`
`4`	`4`	`it('renders basic text', async () => {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import {html, render, until} from '..'`
	`1`	`+import {html, render, until} from '../lib/index.js'`
`2`	`2`
`3`	`3`	`describe('until', () => {`
`4`	`4`	`it('renders a Promise when it resolves', async () => {`