Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Include file extension in all imports #15

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Include file extension in all imports #15

merged 2 commits into from
Jan 26, 2022

Conversation

dgreif
Copy link
Contributor

@dgreif dgreif commented Jan 26, 2022

Because this package is "type": "module", node (and bundlers) will interpret it as ESM and expect file extensions to be included for all relative imports. Our other projects haven't had a huge issue with this because Rollup tends to glaze over it, but we should add these extensions to be ESM compatible.

@dgreif dgreif requested a review from keithamus January 26, 2022 04:19
@dgreif dgreif requested a review from a team as a code owner January 26, 2022 04:19
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dgreif dgreif merged commit 699741d into main Jan 26, 2022
@dgreif dgreif deleted the esm-import-extensions branch January 26, 2022 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants