Set path for CJS actions on Windows #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts how the entrypoint path is constructed for CommonJS and ESM actions on Windows.
- Introduces a conditional that prepends a leading slash only for ESM actions
- Retains the previous behavior for CommonJS actions by replacing Windows path separators with '/'
Comments suppressed due to low confidence (1)
src/commands/run.ts:289
- In the ESM branch, the path is not normalized (i.e., replacing Windows path separators with '/'). This may cause issues if path.resolve returns paths with backslashes on Windows. Consider applying the same normalization as in the CommonJS branch if needed, or add a clarifying comment as to why it is intentionally omitted.
actionType === 'esm'
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
@github/local-actionon CommonJS actions on Windows, the entrypoint should not include a leading slash. ESM actions however, appear to require this.