Add Windows CI Tests #173
Merged
Add Windows CI Tests #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows CI tests by updating several workflow job configurations to use an OS matrix, helping to detect OS-specific issues. Key changes include:
- Refactoring job definitions for TypeScript and JavaScript ESM templates to run on both Ubuntu and Windows.
- Updating the yarn job to use corepack for dependency management.
- Enhancing continuous-delivery workflow triggers with additional path filters.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/continuous-integration.yml | Updates job configurations to include OS matrix tests and corepack usage for yarn |
| .github/workflows/continuous-delivery.yml | Adds path filtering to workflow triggers |
Comments suppressed due to low confidence (1)
.github/workflows/continuous-integration.yml:290
- The 'typescript-esm-yarn' job is still configured to use only Ubuntu. If the goal is to add Windows tests universally, update this job to use a strategy matrix that includes both 'ubuntu-latest' and 'windows-latest'.
runs-on: ubuntu-latest
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the CI/CD workflows to add tests for Windows runners. This should help alleviate OS-specific issues that are encountered.