Add markdown support for .mdx files #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! MDX person here. Looks like this is now alive on the website. I’m not sure this is a good idea. There are some MDX files that are indeed close to markdown. But this also looks really bad for other files. Some examples:
MDX-the-language has a benefit for programmers that want to use their own React/Vue/etc components. The “Non-markdown syntax will just be printed out as plain text” is not correct, as can be seen. What is the reasoning in 8873? Can I convince the people in that discussion that this may not be an improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/github/repos/issues/8873
Adds basic support for rendering .mdx files as markdown. Non-markdown syntax will just be printed out as plain text