fixed unresponsiveness of the iframe in footer #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this code change helps when the screen is a smaller (mobile) size, but when the screen is full size, I noticed that the div is rendering as 300x156 which is much smaller than its original appearance. Are you seeing that as well? Before: After: |
|
@zkoppert Ya, my bad didnt notice that issue earlier, fixed the issue now and the yt iframe is scaling as required. |
zkoppert
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the issue #1254 , the youtube iframe present in footer is not responsive ,i.e., it doesnt fix correctly on mobile screens. This PR fixes the issue.