Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding resources for getting started with GraphiQL on Enterprise - #141

Merged
tcbyrd merged 3 commits into
masterfrom
graphql-enterprise
Jul 12, 2017
Merged

Adding resources for getting started with GraphiQL on Enterprise#141
tcbyrd merged 3 commits into
masterfrom
graphql-enterprise

Conversation

@tcbyrd

@tcbyrd tcbyrd commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

This PR adds examples of how to use GraphiQL with GitHub Enterprise, which is now available in 2.10.0.

Includes a README with instructions for the Electron-based GraphiQL App as well as an example that can be published from GitHub Pages.

@tcbyrd tcbyrd self-assigned this Jun 8, 2017
@tcbyrd
tcbyrd requested a review from azizshamim June 22, 2017 20:03
Comment thread graphql/enterprise/README.md Outdated


#### Setup
The example is already setup with all source files necessary to work with Pages on GitHub Enterprise. You can copy this folder as-is to your own instance, then [configure GitHub Pages to publish the master branch](https://help.github.com/enterprise/user/articles/configuring-a-publishing-source-for-github-pages/). A URL will be created for you automatically.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need more details. I'm not sure what * copy this folder as-is to your own instance* really means.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just an example of cloning it and pushing it to a new remote on your own instance of GHE?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcbyrd Cloning the whole platform-samples repository?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azizshamim Good point. Basically you'd need to copy github/platform-samples/graphql/enterprise. I have all this in its own repo on our internal GHE instance, but wanted to make it available publicly, but yeh having to clone this entire repo isn't a good workflow. Should I just make a public repo in my own account and link to it from here instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcbyrd I think that might be a bit too much redirection. One of these two options might be enough:

  • Document how to clone just the single directory in the repository with sparse-checkout
  • List the files that they need from a clone of the repository.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azizshamim Even with sparse-checkout it's retaining the directory structure, so you'd still have to move all the files into the root of the new repo. I adjusted the wording to be more explicit that you need the entire graphql/enterprise directory in its own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants