Update the graph rendering example to support Octokit >2.0 - #146
Merged
Conversation
nathos
commented
Aug 28, 2017
|
|
||
| CLIENT_ID = ENV['GITHUB_CLIENT_ID'] | ||
| CLIENT_SECRET = ENV['GITHUB_CLIENT_SECRET'] | ||
| CLIENT_ID = ENV['GH_GRAPH_CLIENT_ID'] |
Member
Author
There was a problem hiding this comment.
Setting these back to their prior values because this project has official documentation that we should avoid conflicting with.
Member
Author
There was a problem hiding this comment.
Reverted this in 097a124 as Warden/sinatra_auth_github was still expecting the GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET environment variables.
Contributor
There was a problem hiding this comment.
So does the documentation need updated, then?
Member
Author
There was a problem hiding this comment.
@kylemacey perhaps. I'm not 100% sure why the GH_GRAPH_CLIENT_ID/GH_GRAPH_CLIENT_SECRET_ID wasn't getting passed to Warden. It still wanted GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET to be set.
osararin
approved these changes
Aug 30, 2017
jonico
approved these changes
Oct 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the dependencies for the D3.js rendering example to support modern Octokit versions.