Fix CI: install Playwright browsers after version bump#344
Merged
francinelucca merged 2 commits intodependabot/npm_and_yarn/npm_and_yarn-8ff8a2d82bfrom Mar 3, 2026
Merged
Conversation
Co-authored-by: francinelucca <[email protected]>
Copilot
AI
changed the title
[WIP] Bump the npm_and_yarn group across 1 directory with 2 updates
Fix CI: install Playwright browsers after version bump
Mar 3, 2026
68369a2
into
dependabot/npm_and_yarn/npm_and_yarn-8ff8a2d82b
2 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Node CI workflow to ensure Playwright’s Chromium browser binary is installed in CI after upgrading Playwright, preventing test failures due to missing browser revisions.
Changes:
- Split the previous combined npm step into separate install and test steps.
- Added an explicit
npx playwright install --with-deps chromiumstep before running tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+22
| - name: npm install | ||
| run: npm install |
There was a problem hiding this comment.
In CI, prefer npm ci over npm install when a package-lock.json is committed. It provides reproducible installs and will fail fast if package.json/lockfile drift (also consistent with .github/workflows/publish.yml using npm ci).
Suggested change
| - name: npm install | |
| run: npm install | |
| - name: npm ci | |
| run: npm ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright was bumped from 1.28.1 to 1.58.2, which uses a different Chromium revision. The CI was failing because the browser binary wasn't present on the runner.
Changes
.github/workflows/test.yml: Splitnpm itinto discrete steps, insertingnpx playwright install --with-deps chromiumbetween install and test so the correct browser binaries are available before tests run.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.