Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert project to Typescript - #18

Merged
koddsson merged 18 commits into
masterfrom
typescript
Apr 27, 2020
Merged

Convert project to Typescript#18
koddsson merged 18 commits into
masterfrom
typescript

Conversation

@koddsson

Copy link
Copy Markdown
Contributor

I used github/tab-container-element#25 as a template.

@koddsson
koddsson requested a review from a team April 23, 2020 16:57
@koddsson

Copy link
Copy Markdown
Contributor Author

Ah! We still need the UMD build since we are importing packages from npm. I did start this because I want to get rid of the form-data-entries dependency so I might see if I can easily get rid of selector-set and then this module will be with out any dependencies πŸ‘―

@keithamus keithamus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good cleanup πŸ‘

We don't need a UMD build for github, so you could make it a breaking change and drop the UMD build, opting for ES Module only build.

@koddsson koddsson mentioned this pull request Apr 24, 2020
@koddsson
koddsson merged commit 7504385 into master Apr 27, 2020
@koddsson
koddsson deleted the typescript branch April 27, 2020 12:57
@koddsson koddsson mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants