This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Remove ability to load blobs/projects from Git repos. #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 21, 2019 16:36
patrickt
commented
Oct 22, 2019
| Read (FromGitRepo path sha (ExcludePaths excludePaths)) k -> rethrowing (readBlobsFromGitRepo path sha excludePaths mempty) >>= k | ||
| Read (FromGitRepo path sha (ExcludeFromHandle handle)) k -> rethrowing (readPathsFromHandle handle >>= (\x -> readBlobsFromGitRepo path sha x mempty)) >>= k | ||
| Read (FromGitRepo path sha (IncludePaths includePaths)) k -> rethrowing (readBlobsFromGitRepo path sha mempty includePaths) >>= k | ||
| Read (FromGitRepo path sha (IncludePathsFromHandle h)) k -> rethrowing (readPathsFromHandle h >>= readBlobsFromGitRepo path sha mempty) >>= k |
There was a problem hiding this comment.
I have always loathed this code path and am glad to see it gone.
| @@ -67,7 +67,6 @@ common dependencies | |||
| , semantic-source ^>= 0.0 | |||
| , semilattices ^>= 0.0.0.3 | |||
| , streaming ^>= 0.2.2.0 | |||
| , streaming-bytestring ^>= 0.1.6 | |||
There was a problem hiding this comment.
We don’t use this anywhere other than the parse-examples and semantic-python tests, so it can be dropped from the common one.
1 task
robrix
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to internal architecture changes, we no longer need this facility. Since this entails a number of dependencies and a good deal of somewhat-involved code, let’s kill it.