Extend processPropertyIdentity to handle Element
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [github#62][] Extends the `processPropertyIdentity` function from the `processors` module to pass-through `Element` instances, instead of coercing them through calls to `String()`. In order to accommodate that change, this commit also extends the `TemplatePart` interface to accept `Element` instances for its `value:` property. The change to the `createTreeWalker` invocation within `collectParts` was highlighted by TypeScript, as the final `boolean` argument doesn't conform to the [createTreeWalker][] signature. It was a necessary change to build the project and execute the test suite locally. [github#62]: github#62 [createTreeWalker]: https://developer.mozilla.org/en-US/docs/Web/API/Document/createTreeWalker
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
rezrah
approved these changes
Dec 12, 2022
🎊! Could you grant permission for this PR's CI to execute the test suite? |
Done 👍 |
|
@rezrah @keithamus what are the next steps involved in incorporating these changes into a release? |
seanpdoyle
added a commit
to seanpdoyle/template-parts
that referenced
this pull request
Dec 9, 2024
Related to [github#62][] (see [3.2. Template Parts and Custom Template Process Callback][]) Follow-up to [github#65][] While the changes made in [github#65][] improved support for `Element` parts, the expansion from `string` to `Element | string` was not broadened enough. While all `Element` instances are DOM Nodes, not all DOM Nodes are `Element` instances. For example, this change enables support for [DocumentFragment][] instances (generated from classes like [Range][] or properties like [HTMLTemplateElement.content][]), where prior support resulted in templating the `[object DocumentFragment]` text string instead of the fragment's `Node` instances. [github#62]: github#62 [3.2. Template Parts and Custom Template Process Callback]: https://github.com/WICG/webcomponents/blob/159b1600bab02fe9cd794825440a98537d53b389/proposals/Template-Instantiation.md#32-template-parts-and-custom-template-process-callback [github#65]: github#65 [DocumentFragment]: https://developer.mozilla.org/en-US/docs/Web/API/DocumentFragment [HTMLTemplateElement.content]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLTemplateElement/content
|
I've opened #73 as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes github/template-parts#62
Extends the
processPropertyIdentityfunction from theprocessorsmodule to pass-throughElementinstances, instead of coercing them through calls toString(). In order to accommodate that change, this commit also extends theTemplatePartinterface to acceptElementinstances for itsvalue:property.The change to the
createTreeWalkerinvocation withincollectPartswas highlighted by TypeScript, as the finalbooleanargument doesn't conform to the createTreeWalker signature. It was a necessary change to build the project and execute the test suite locally.