Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GHES disable SSL verify support (for custom certification chains usage) #1207

@axel3rd

Description

@axel3rd

Overview of the Feature

Provide a way to disable SSL verification on GitHub Enterprise Server (from Lambda interactions).

Reproduce the Error

When GitHub Enterprise Server is deployed (on premise) with a "custom" certificate, the scale-up Lambda hasn't this certification chains and fails with:

request to https://github.staging.company.com/api/v3/app/installations/xx/access_tokens failed, reason: unable to verify the first certificate

Motivation for or Use Case

In some case, GHES could be deployed with a custom certification chains, because a wildcard DigiCert/VeriSign could be too much (sample: for non-production platform).

Suggest a Fix

A (simple) way could be to disable SSL verification at NodeJs level, by providing NODE_TLS_REJECT_UNAUTHORIZED environment variable:

NODE_TLS_REJECT_UNAUTHORIZED=0 

Pull-Request will come with this suggestion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions