-
Notifications
You must be signed in to change notification settings - Fork 679
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
The way we parse runner parameters is becoming hard to maintain and extend. Some refactoring required.
Review on PR #1374
I think it might be better when working with these command to use a string array and then join then with a space. Rather than having to worry about spaces in all the strings etc.
runnerServiceConfig
could be defined as a string array above and you can merge the arrays and join.
Originally posted by @ScottGuymer in https://github.com/philips-labs/terraform-aws-github-runner/pull/1374#discussion_r768531638
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed