chore: Refactor runnerServiceConfig to be an array of strings #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run on branch fix test
|
I see Sonar complaining about some duplication of code in the scale-up.test.ts. I actually disagree here with Sonar, trying to reduce the duplication would result in less readable/understandable testing code. What is your approach in this case usually? |
|
@ulich please ignore Sonar for now, it was an experiment to add it. Still have to see how we can value out of sonar, but for now ignore it. Will remove it next week |
|
Ok. Then the PR is ready for review |
npalm
approved these changes
Mar 15, 2022
ulich
added a commit
to ulich/terraform-aws-github-runner
that referenced
this pull request
Mar 31, 2022
…unners#1842) run on branch fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/philips-labs/terraform-aws-github-runner/issues/1522