feat(runners): Add possibility to not create ebs #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if its a proper solution, really hard to test it as module is complicated. Goal is to change behaviour of module only in case that someone set variable to |
fce77ba to
dfa22e8
Compare
|
Can you share some config how you setup the ebs? Are you using an AMI (ubuntu) I guess? |
We are using ubuntu AMI and dont setup ebs (module takes default) in that case which is |
|
Thx, will check asap |
@npalm have you managed to check it? |
npalm
approved these changes
Mar 10, 2022
ulich
pushed a commit
to ulich/terraform-aws-github-runner
that referenced
this pull request
Mar 31, 2022
Co-authored-by: Grzegorz Cwiklinski <[email protected]@smartpension.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: https://github.com/philips-labs/terraform-aws-github-runner/issues/1769