feat: AWS Terraform provider 4.x #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2022
|
Verified with the default example including upgrade |
ScottGuymer
previously approved these changes
May 4, 2022
BREAKING CHANGE: The module is upgraded to AWS Terraform provider 4.x
manual merge of https://github.com/philips-labs/terraform-aws-github-runner/pull/1915 Co-authored-by: Julius Adamek <[email protected]>
BREAKING CHANGE: var.volume_size replaced by var.block_device_mappings
|
@ScottGuymer PR is ready to be reviewed |
ScottGuymer
reviewed
May 9, 2022
* fix: block name should default to `dev/xvda` * fix: Wrong default for block device mapping Co-authored-by: Gus Fune <[email protected]>
ScottGuymer
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to merge PR to support Terraform Provider 4.x
See #1938