Open
Conversation
Chemaclass
approved these changes
Feb 10, 2023
Chemaclass
left a comment
There was a problem hiding this comment.
Great idea! Highlighting phel files using common lisp would be a great improvement, especially people will be able to understand the code easier when reading it directly from GitHub 🧠💡
lildude
previously requested changes
Feb 17, 2023
Member
lildude
left a comment
There was a problem hiding this comment.
Popularity is not sufficient for inclusion yet, but that doesn't mean you can't address the identified issues in the mean time.
See inline comment.
Please remove the core.phel file. It's massive and waaaay too big.
Please also remove the sample.phel file as this is clearly a "Hello world" sample and not a real-world example.
d1fb008 to
ca7013f
Compare
ca7013f to
acc1601
Compare
70fec6c to
92773e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
There are more than 480 files in Github using the
.phelextension.Some remarkable projects:
Plugins for different applications
📓 Checklist:
Please let me know if something is missing. I'd be glad to keep improving the PR if necessary! 🤞🏼