Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump mocha dependency version #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

Bump mocha dependency version #6499

merged 1 commit into from
Aug 3, 2023

Conversation

lildude
Copy link
Member

@lildude lildude commented Aug 3, 2023

Description

Bumping the minimum version of mocha used for testing.

This is needed because Mocha < 2.1.0 is not compatible with Minitest 5.19.0 and later: freerange/mocha#614

This will address these test failures:

[...]
/home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test/adapter.rb:26:in `included': uninitialized constant MiniTest (NameError)

          Mocha::ExpectationErrorFactory.exception_class = ::MiniTest::Assertion
                                                           ^^^^^^^^^^
Did you mean?  Minitest
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test.rb:50:in `include'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test.rb:50:in `activate'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/mocha-1.16.1/lib/mocha/minitest.rb:5:in `<top (required)>'
	from /home/runner/work/linguist/linguist/test/helper.rb:3:in `require'
	from /home/runner/work/linguist/linguist/test/helper.rb:3:in `<top (required)>'
	from /home/runner/work/linguist/linguist/test/test_blob.rb:1:in `require_relative'
	from /home/runner/work/linguist/linguist/test/test_blob.rb:1:in `<top (required)>'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21:in `require'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21:in `block in <main>'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `select'
	from /home/runner/work/linguist/linguist/vendor/bundle/ruby/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!
[...]

Checklist:

N/A

@lildude lildude requested a review from a team as a code owner August 3, 2023 08:27
@lildude lildude mentioned this pull request Aug 3, 2023
Merged
@lildude lildude merged commit 916bd8f into master Aug 3, 2023
@lildude lildude deleted the lildude/bump-mocha-dep-ver branch August 3, 2023 09:03
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lildude