Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add cs.pp extension to C# #6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add cs.pp extension to C# #6679

merged 3 commits into from
Mar 8, 2024

Conversation

DecimalTurn
Copy link
Contributor

Adding cs.pp extension to C# per #6662

Checklist:

@DecimalTurn DecimalTurn requested a review from a team as a code owner January 16, 2024 23:19
@DecimalTurn
Copy link
Contributor Author

The error during the checks seems unrelated.

image

It looks like it could be due to https://github.com/tabatkins/bikeshed now redirecting to https://github.com/speced/bikeshed.

@lildude
Copy link
Member

lildude commented Jan 17, 2024

It looks like it could be due to https://github.com/tabatkins/bikeshed now redirecting to https://github.com/speced/bikeshed.

Nope. It's because https://github.com/tiabeast/vscode-vba-json has gone AWOL:

[...]
Cloning into '/home/runner/work/linguist/linguist/vendor/grammars/vscode-vba-json'...
fatal: could not read Username for 'https://github.com/': No such device or address
fatal: clone of 'https://github.com/tiabeast/vscode-vba-json.git' into submodule path '/home/runner/work/linguist/linguist/vendor/grammars/vscode-vba-json' failed
Failed to clone 'vendor/grammars/vscode-vba-json'. Retry scheduled
Cloning into '/home/runner/work/linguist/linguist/vendor/grammars/vscode-vba-json'...
fatal: could not read Username for 'https://github.com/': No such device or address
fatal: clone of 'https://github.com/tiabeast/vscode-vba-json.git' into submodule path '/home/runner/work/linguist/linguist/vendor/grammars/vscode-vba-json' failed
[...]

I've just merged #6678 which switches sources.

lildude
lildude approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit df4abbc Mar 8, 2024
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
@DecimalTurn DecimalTurn deleted the cs-pp branch February 17, 2025 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DecimalTurn @lildude