Remove possessive qualifier for NASL #7259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lildude
approved these changes
Mar 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to #7240, this PR removes an instance of a possessive qualifier. Possessive qualifiers aren't supported in re2, hence this PR increases portability of Linguist's heuristics.
Removing this from the NASL heuristic could theoretically reduce performance, but due to the fact that the possessive qualifier is close to the end of the regex and that the structure of the regex prevents multple branching while backtracking, this change should be unnoticable in practice.
Note that with this PR and #7242, Linguist's heuristics should now be fully compatible with RE2's syntax except for
Vim Help File,Hosts FileandAdblock Filter List. 🎉Checklist:
NA