Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Assembly heuristics to remove char class duplication #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix Assembly heuristics to remove char class duplication #7265

merged 1 commit into from
Mar 5, 2025

Conversation

donno2048
Copy link
Contributor

@donno2048 donno2048 commented Mar 4, 2025 •
edited by lildude
Loading

#7229 introduced changes to the Assembly heuristics that included character class duplication which were reported as warnings in CI but missed at the time:

/home/runner/work/linguist/linguist/lib/linguist/heuristics.rb:91: warning: character class has duplicated range: /^\s+(i?)db\s+[\d\w]/
/home/runner/work/linguist/linguist/lib/linguist/heuristics.rb:91: warning: character class has duplicated range: /(?i-mx:mov\s+[^\s]+,)|(?-mix:^\s+(i?)db\s+[\d\w])/
/home/runner/work/linguist/linguist/lib/linguist/heuristics.rb:91: warning: character class has duplicated range: /^\s+(?i)db\s+[\d\w]/
/home/runner/work/linguist/linguist/lib/linguist/heuristics.rb:91: warning: character class has duplicated range
/home/runner/work/linguist/linguist/lib/linguist/heuristics.rb:129: warning: character class has duplicated range

For future reference, @donno2048, useful PR bodies like this are preferred over simple pings as context is needed for reviewing by those unfamiliar at the time or who question the change in future.

@donno2048 donno2048 requested a review from a team as a code owner March 4, 2025 20:52
@lildude lildude changed the title Fix character class has duplicated range warning Fix Assembly heuristics to remove char class duplication Mar 5, 2025
lildude
lildude reviewed Mar 5, 2025
View reviewed changes
@lildude lildude added this pull request to the merge queue Mar 5, 2025
Merged via the queue into github-linguist:main with commit ccb32e9 Mar 5, 2025
5 checks passed
@donno2048 donno2048 deleted the patch-1 branch March 5, 2025 10:43
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donno2048 @lildude