-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add support for Bru (Bruno Markup Language) #7560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
Along with that, a cache of the grammar licence file should have been created if you'd followed the instructions in the CONTRIBUTING.md file. This needs to be included in this PR.
Please also link to the source of the sample in the PR template and state the licence of the sample; you removed these lines rather than filling them in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. You've included files that you shouldn't have and still don't appear to have followed the instructions as you appear to have manually added a second copy of the grammar.
You've also misunderstood the comment about the license for the sample files: we need a link to the source of the file (not a link to your fork of Linguist) and a simple comment about their licenses.
As for the cached license files, we only need the
Thank you. |
Whoops "… one from the remaining grammar for the language". |
This reverts commit 960936a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Important
The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.
Close #7472
Description
Checklist
#F4AA41