Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ludovicobesana
Copy link
Contributor

@ludovicobesana ludovicobesana commented Sep 3, 2025

Close #7472

Description

Screenshot 2025-09-03 alle 02 16 33

Checklist

@ludovicobesana ludovicobesana requested a review from a team as a code owner September 3, 2025 00:17
@ludovicobesana ludovicobesana marked this pull request as draft September 3, 2025 00:17
@ludovicobesana ludovicobesana marked this pull request as ready for review September 3, 2025 00:28
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Along with that, a cache of the grammar licence file should have been created if you'd followed the instructions in the CONTRIBUTING.md file. This needs to be included in this PR.

Please also link to the source of the sample in the PR template and state the licence of the sample; you removed these lines rather than filling them in.

@ludovicobesana ludovicobesana marked this pull request as draft September 3, 2025 10:01
@ludovicobesana ludovicobesana marked this pull request as ready for review September 3, 2025 23:09
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. You've included files that you shouldn't have and still don't appear to have followed the instructions as you appear to have manually added a second copy of the grammar.

You've also misunderstood the comment about the license for the sample files: we need a link to the source of the file (not a link to your fork of Linguist) and a simple comment about their licenses.

As for the cached license files, we only need the

@ludovicobesana
Copy link
Contributor Author

Whoops. You've included files that you shouldn't have and still don't appear to have followed the instructions as you appear to have manually added a second copy of the grammar.

You've also misunderstood the comment about the license for the sample files: we need a link to the source of the file (not a link to your fork of Linguist) and a simple comment about their licenses.

As for the cached license files, we only need the

Thank you.
Gotcha, "As for the cached license files, we only need the"?

@lildude
Copy link
Member

lildude commented Sep 8, 2025

As for the cached license files, we only need the

Whoops "… one from the remaining grammar for the language".

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Sep 15, 2025
Merged via the queue into github-linguist:main with commit 94436d2 Sep 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Bru (Bruno’s plain-text API collection format)
2 participants