Fix tests #571
Merged
Fix tests #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR tests are from earlier, before I removed them. The push tests passed. |
|
@j-rewerts Won't contributors want to be able to run the tests and possibly make changes to the tests? |
|
Yeah so this change means contributors will need to request a private access token, or set up their own test account for running the tests with. I'll add something to the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears GitHub requires accounts emails to be verified, which was causing our test suite to fail. I've added a new user that we have better control over. I also decided to use a personal access token, rather than exposing the password.
I'm hoping to switch our dev workflow to be more secure. In the past, we exposed our test user credentials publicly. A secure workflow could be:
This is extra work for sure, but it will allow us to have a secure CI user while also accepting community contributions.