Use /:path instead of ?path=:path to get contents #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Crap, didn't realize there was already a PR for this. Is this project really maintained anymore? |
|
Well, this PR is only 2 months old, and the author has not been very active on github this year, so we can leave him a little bit of time 😄 |
|
Its 5 months old now, lol. |
This was referenced May 21, 2014
w35l3y
added a commit
to w35l3y/github-js
that referenced
this pull request
May 21, 2014
It was fixed already
|
@michael are you interested in merging this? |
|
@raphink Howdy, I'm helping maintain this. Mind updating your PR? Would love to merge it. Thanks! 👍 |
|
Also, this is a dupe of #127, or rather, that is a dupe of this. I don't care which I merge, will merge the one fixed fastest whilst closing the other. Thanks! 🏁 |
|
@Aendrew Just rebased it. |
|
💥 |
aendra-rininsland
pushed a commit
that referenced
this pull request
Apr 8, 2015
Use /:path instead of ?path=:path to get contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
pathin the query string does not seem to work anymore with the Github API (I'm admittedly guilty of not seeking to know why). The API documentation says to use:which is what this patch does (and it works ;-)).