Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jlord
Copy link
Collaborator

@jlord jlord commented Jan 6, 2014

I was working off the GitHub readme this weekend for a bit and finally realized that it is out of date a bit and that the NPM version is more current.

This pull request adds the missing "auth" parts of the access object that are on the NPM readme but not this one.

@mattpass
Copy link
Collaborator

mattpass commented Jan 6, 2014

The auth parts were removed as it's a bit unnecessary to ask the user to set this. If they have a user/pass combo it has to be basic, if they have a token it has to be oauth, no need to make the user state that?

https://github.com/michael/github/blob/master/github.js#L60 detects what is passed thru and sets the auth type automatically. If there should be any tweaks added, it should be there.

The NPM side of things I think its a bit out of date and this manual is more correct.

@mattpass
Copy link
Collaborator

mattpass commented Jan 6, 2014

BTW, a while back Michael got quite busy with other things and I so I offered to help maintain items here (took it from 0.7 to 0.9 in whatever time I've had). Unfortunately tho I've also got v busy and so I think you offered to help maintain things? Is that still possible as people are understandably eager to have PR's etc merged?

Just need to know if you'll find time soon or if I need to carry on somehow? :)

@jlord
Copy link
Collaborator Author

jlord commented Jan 6, 2014

Hmm, it wouldn't work for me without the "auth" bit. For both the username and password and token scenarios.

I can still help out maintaining. I thought that I was more of an extra hand and got wrapped up in some other stuff for a bit but will totally really ramp up over here.

@michael
Copy link
Collaborator

michael commented Jan 6, 2014

Hey guys!

Glad you're helping out here, Jessica! As said I'm wrapped up in work on Substance-related projects and I'm not actively using the Github wrapper at the moment, which makes me a really bad maintainer. ;)

I'm hitting the merge button now. Stating the auth option explicitly makes total sense, even though it can be left out.

michael added a commit that referenced this pull request Jan 6, 2014
@michael michael merged commit 5283017 into master Jan 6, 2014
@mattpass
Copy link
Collaborator

mattpass commented Jan 6, 2014

Sounds good Jessica. Will give a hand whenever I have spare time too.

@ingalls ingalls deleted the edit-readme branch December 11, 2014 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants