fix: replace bun/TypeScript format check with cargo fmt in pr-standards.yml#159
Merged
RandyMcMillan merged 1 commit intoMay 3, 2026
Conversation
…ds.yml Agent-Logs-Url: https://github.com/gnostr-org/gnostr/sessions/9ecb55e5-75c0-48cf-8e91-8c5dd594b220 Co-authored-by: RandyMcMillan <[email protected]>
Copilot created this pull request from a session on behalf of
RandyMcMillan
May 3, 2026 03:17
View session
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
f5ee026
into
copilot/fix-action-run-step-13
29 of 43 checks passed
There was a problem hiding this comment.
Pull request overview
This PR updates the PR Standards workflow so its format check uses the Rust toolchain and cargo fmt instead of Bun/TypeScript commands that do not exist in this repository. It aligns the formatting job with the repo’s Rust-based CI setup, but the workflow still has a functional gap because it runs under pull_request_target.
Changes:
- Removed Bun setup and the nonexistent TypeScript formatting script from
check-format. - Added
dtolnay/rust-toolchain@stablewith therustfmtcomponent. - Replaced the custom “run formatter then inspect git diff” logic with
cargo fmt --all --check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+22
| - name: Check Rust formatting | ||
| run: cargo fmt --all --check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-formatjob inpr-standards.ymlwas copied from a Node.js/TypeScript project and ranbun install+bun run script/format.ts— neither of which exist in this Rust repo, causing the job to immediately fail.Changes
.github/workflows/pr-standards.yml: Replaced the bun setup,bun install, and TypeScript format script steps withdtolnay/rust-toolchain@stable(withrustfmtcomponent) andcargo fmt --all --check, consistent with how formatting is enforced inci.yml.