Attachment support repository route #15580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regression (#15088) was not backported so I think this one wouldn't need a backport. |
|
If the attachment ids are guaranteed to be uuids, I think I would still prefer a regex route so users can have |
|
Actually this is LGTM because it seems it's not possible to link a image from the repo in issue comments so there is no actual namespace conflict. |
silverwind
approved these changes
Apr 22, 2021
KN4CK3R
approved these changes
Apr 23, 2021
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new route reuse old function to allow a new entry for easier reference from comments/issues .
Should fix #15550