Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a new table issue_index to store the max issue index so that issue could be deleted with no duplicated index #15599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 14, 2021
Merged

Add a new table issue_index to store the max issue index so that issue could be deleted with no duplicated index #15599

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0bdfac1
Add a new table issue_index to store the max issue index so that issu…
lunny Apr 23, 2021
a78e6cb
Fix pull index
lunny Apr 23, 2021
8d3df3c
Add tests for concurrent creating issues
lunny Apr 23, 2021
497da8e
Fix lint
lunny Apr 23, 2021
f3fcec4
Fix tests
lunny Apr 24, 2021
f60ac9d
Fix postgres test
lunny Apr 29, 2021
3253f5d
Add test for migration v180
lunny May 7, 2021
f5ab5d9
Rename wrong test file name
lunny Jun 1, 2021
8e4e1f5
Merge branch 'main' into lunny/improve_issue_index
6543 Jun 10, 2021
5bff46e
Merge branch 'main' into lunny/improve_issue_index
lafriks Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix postgres test
  • Loading branch information
@lunny
lunny committed Jun 8, 2021
commit f60ac9d838fef5f775348b2063658db773b7e598
4 changes: 2 additions & 2 deletions models/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ func upsertResourceIndex(e Engine, tableName string, groupID int64) (err error)
switch {
case setting.Database.UseSQLite3 || setting.Database.UsePostgreSQL:
_, err = e.Exec(fmt.Sprintf("INSERT INTO %s (group_id, max_index) "+
"VALUES (?,1) ON CONFLICT (group_id) DO UPDATE SET max_index = max_index+1",
tableName), groupID)
"VALUES (?,1) ON CONFLICT (group_id) DO UPDATE SET max_index = %s.max_index+1",
tableName, tableName), groupID)
case setting.Database.UseMySQL:
_, err = e.Exec(fmt.Sprintf("INSERT INTO %s (group_id, max_index) "+
"VALUES (?,1) ON DUPLICATE KEY UPDATE max_index = max_index+1", tableName),
Expand Down