Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove semver compatible flag and change pypi to an array of test cases #21708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Remove semver compatible flag and change pypi to an array of test cases #21708

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9035c41
Simplify tests and refactor name/version checks
Racer159 Nov 7, 2022
c607b93
Expressly escape . and - in regex
Racer159 Nov 7, 2022
5f730ca
Add another test case
Racer159 Nov 7, 2022
3242b2c
Flip boolean in name+version check
Racer159 Nov 7, 2022
c9372be
Update routers/api/packages/pypi/pypi_test.go
Racer159 Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add another test case
  • Loading branch information
@Racer159
Racer159 committed Nov 7, 2022
commit 5f730ca4b4f732730c1cd2146ef1c72206fa76a5
1 change: 1 addition & 0 deletions routers/api/packages/pypi/pypi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ func TestHasInvalidMetadata(t *testing.T) {
// https://peps.python.org/pep-0440/#appendix-b-parsing-version-strings-with-regular-expressions

// Valid Cases
assert.False(t, hasInvalidMetadata("A", "1.0.1"))
assert.False(t, hasInvalidMetadata("Test.Name.1234", "1.0.1"))
assert.False(t, hasInvalidMetadata("test_name", "1.0.1"))
assert.False(t, hasInvalidMetadata("test-name", "1.0.1"))
Expand Down