Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add option to prohibit fork if user reached maximum limit of repositories #21848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from Dec 27, 2022
Merged

Add option to prohibit fork if user reached maximum limit of repositories #21848

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b2bb0f3
Prohibit fork if user reached maximum limit of repositories
Nov 17, 2022
fc21dbb
Add test
Nov 17, 2022
3eca445
Update templates/repo/pulls/fork.tmpl
Nov 19, 2022
9f88874
CanForkRepo returns if user login can fork a repository
Nov 19, 2022
572aa44
Apply suggestions from code review
Nov 20, 2022
97f3e27
use base/alert to generate warning
Nov 20, 2022
3c3fbf9
make fmt
Nov 20, 2022
08259ae
Add option to allow fork repositories without maximum number limit
Nov 26, 2022
1731a10
Merge branch 'main' into bugfix/fork-reach-limit
6543 Dec 23, 2022
40af00f
Apply suggestions from code review
Dec 24, 2022
e28ce1b
Update services/repository/fork_test.go
Dec 24, 2022
2bb727d
Update services/repository/fork_test.go
Dec 24, 2022
79122cd
Merge branch 'main' into bugfix/fork-reach-limit
6543 Dec 25, 2022
05426cc
Merge branch 'main' into bugfix/fork-reach-limit
jolheiser Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test 
Signed-off-by: Xinyu Zhou <[email protected]>
  • Loading branch information
Xinyu Zhou committed Nov 17, 2022
commit fc21dbbe16ae79c5724febd9ee2789d02639698c
13 changes: 12 additions & 1 deletion services/repository/fork_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func TestForkRepository(t *testing.T) {
// user 13 has already forked repo10
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 13})
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 10})

fork, err := ForkRepository(git.DefaultContext, user, user, ForkRepoOptions{
BaseRepo: repo,
Name: "test",
Expand All @@ -30,4 +29,16 @@ func TestForkRepository(t *testing.T) {
assert.Nil(t, fork)
assert.Error(t, err)
assert.True(t, IsErrForkAlreadyExist(err))

// user not reached maximum limit of repositories
assert.False(t, repo_model.IsErrReachLimitOfRepo(err))
// user has reached maximum limit of repositories
user.MaxRepoCreation = 0
fork2, err := ForkRepository(git.DefaultContext, user, user, ForkRepoOptions{
BaseRepo: repo,
Name: "test",
Description: "test",
})
assert.Nil(t, fork2)
assert.True(t, repo_model.IsErrReachLimitOfRepo(err))
}