Always use HTML attributes for avatar size #31509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
approved these changes
Jun 28, 2024
delvh
approved these changes
Jun 28, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix markdown preview $$ support (go-gitea#31514) Add Passkey login support (go-gitea#31504) Use stable version of fabric (go-gitea#31526) Always use HTML attributes for avatar size (go-gitea#31509) Add initial typescript config and use it for eslint,vitest,playwright (go-gitea#31186) Support legacy _links LFS batch responses (go-gitea#31513) Fix JS error with disabled attachment and easymde (go-gitea#31511)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many avatars were rendered in HTML with certain width/height but then resized again in CSS. This was pointless so I removed all these cases and made the HTML size match the previous render size.
Also did a few CSS cleanups in the tribute rendering: