Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix createElementFromAttrs bug #31751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix createElementFromAttrs bug #31751

merged 3 commits into from
Aug 1, 2024

Conversation

wxiaoguang
Copy link
Contributor

The "false" value was not handled correctly, it would cause bugs in the future (fortunately, this behavior is not used in code yet).

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 1, 2024
silverwind
silverwind reviewed Aug 1, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2024
@lafriks lafriks enabled auto-merge (squash) August 1, 2024 19:01
@lafriks lafriks merged commit e367835 into go-gitea:main Aug 1, 2024
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 1, 2024
@wxiaoguang wxiaoguang deleted the fix-create-from-attr branch August 2, 2024 01:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c400a49 
* giteaofficial/main:
  Clear up old Actions logs (go-gitea#31735)
  Fix createElementFromAttrs bug (go-gitea#31751)
  bump vue-bar-graph (go-gitea#31705)
  Use UTC as default timezone when schedule Actions cron tasks (go-gitea#31742)
  Add permission description for API to add repo collaborator (go-gitea#31744)
  Clarify Actions resources ownership (go-gitea#31724)
  Exclude protected branches from recently pushed (go-gitea#31748)
  [skip ci] Updated translations via Crowdin
  Distinguish LFS object errors to ignore missing objects during migration (go-gitea#31702)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @lunny @silverwind @lafriks @delvh @GiteaBot