Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar #32570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar #32570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c621f9a
Update the list of watchers and stargazers when clicking watch/unwatc…
yardenshoham Nov 19, 2024
bb88042
Merge remote-tracking branch 'upstream/main' into issues/32561
yardenshoham Nov 20, 2024
4f633ca
Add comments and reduce abstraction levels
yardenshoham Nov 20, 2024
1c81461
Mention manual testing
yardenshoham Nov 20, 2024
92bc292
Format
yardenshoham Nov 20, 2024
da86679
simpilfy
wxiaoguang Nov 21, 2024
f00c491
outerHTML
wxiaoguang Nov 21, 2024
09aac88
CurrentURL
wxiaoguang Nov 21, 2024
b1aa34a
remove PageIsWatchers and PageIsStargazers because not used
wxiaoguang Nov 21, 2024
ae207c0
Merge branch 'main' into issues/32561
yardenshoham Nov 22, 2024
61c882c
Update routers/web/repo/repo.go
yardenshoham Nov 22, 2024
ab2843b
Merge branch 'main' into issues/32561
GiteaBot Nov 22, 2024
8f073fa
Merge branch 'main' into issues/32561
GiteaBot Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions routers/web/repo/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,9 @@ func Action(ctx *context.Context) {
ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
}

// see the `hx-trigger="refreshUserCards ..."` comments in tmpl
ctx.RespHeader().Add("hx-trigger", "refreshUserCards")

switch ctx.PathParam(":action") {
case "watch", "unwatch", "star", "unstar":
// we have to reload the repository because NumStars or NumWatching (used in the templates) has just changed
Expand Down
3 changes: 0 additions & 3 deletions routers/web/repo/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,8 +1123,6 @@ func RenderUserCards(ctx *context.Context, total int, getter func(opts db.ListOp
func Watchers(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("repo.watchers")
ctx.Data["CardsTitle"] = ctx.Tr("repo.watchers")
ctx.Data["PageIsWatchers"] = true

RenderUserCards(ctx, ctx.Repo.Repository.NumWatches, func(opts db.ListOptions) ([]*user_model.User, error) {
return repo_model.GetRepoWatchers(ctx, ctx.Repo.Repository.ID, opts)
}, tplWatchers)
Expand All @@ -1134,7 +1132,6 @@ func Watchers(ctx *context.Context) {
func Stars(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("repo.stargazers")
ctx.Data["CardsTitle"] = ctx.Tr("repo.stargazers")
ctx.Data["PageIsStargazers"] = true
RenderUserCards(ctx, ctx.Repo.Repository.NumStars, func(opts db.ListOptions) ([]*user_model.User, error) {
return repo_model.GetStargazers(ctx, ctx.Repo.Repository, opts)
}, tplWatchers)
Expand Down
12 changes: 11 additions & 1 deletion templates/repo/user_cards.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
<div class="user-cards">
<!-- Refresh the content if a htmx response contains "HX-Trigger" header.
This usually happens when a user stays on the watchers/stargazers page
when they watched/unwatched/starred/unstarred and the list should be refreshed.
To test go to the watchers page and click the watch button. The user cards should reload.
At the moment, no JS initialization would re-trigger (fortunately there is no JS for this page).
-->
<div class="no-loading-indicator tw-hidden"></div>
<div class="user-cards"
hx-trigger="refreshUserCards from:body" hx-indicator=".no-loading-indicator"
hx-get="{{$.CurrentURL}}" hx-swap="outerHTML" hx-select=".user-cards"
>
{{if .CardsTitle}}
<h2 class="ui dividing header">
{{.CardsTitle}}
Expand Down
Loading