Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support choose email when creating a commit via web UI #33432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2025
Merged

Support choose email when creating a commit via web UI #33432

merged 2 commits into from
Jan 30, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 29, 2025 •
edited
Loading

Initial PR for #24469

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 29, 2025
@wxiaoguang
Copy link
Contributor Author

image

This was referenced Jan 29, 2025
Open
Closed
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 29, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 29, 2025
@wxiaoguang wxiaoguang force-pushed the support-choose-email branch 4 times, most recently from d732ea7 to 54601de Compare January 29, 2025 14:54
@wxiaoguang wxiaoguang force-pushed the support-choose-email branch from 54601de to 8ece4b8 Compare January 29, 2025 14:59
@lunny
Copy link
Member

lunny commented Jan 29, 2025 •
edited
Loading

Can you also add the options when

  • upload file page
  • delete file page
  • merging a pull request or creating an auto merge merging task
  • creating a wiki page
  • apply patch page
  • cherry-pick page
  • revert page

@wxiaoguang
Copy link
Contributor Author

Can you also add the options when

Next PRs

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2025
@silverwind silverwind changed the title Support choose email when createing a commit via web UI Support choose email when creating a commit via web UI Jan 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 30, 2025 01:00
@wxiaoguang wxiaoguang merged commit 256b94e into go-gitea:main Jan 30, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the support-choose-email branch January 30, 2025 09:14
@wxiaoguang wxiaoguang mentioned this pull request Jan 30, 2025
Merged
@wxiaoguang
Copy link
Contributor Author 

* upload file page
* delete file page
* apply patch page
* cherry-pick page
* revert page

-> Support choose email when creating a commit via web UI (more) #33445

wxiaoguang added a commit that referenced this pull request Jan 31, 2025
@wxiaoguang
Support choose email when creating a commit via web UI (more) (#33445)
5a7b42d 
Follow #33432
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot