Add workflow_run api + webhook #33964
Open
+2,802
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…stopherHX/33964-1
…stopherHX/33964-1
* add workflow_run action trigger + webhook test * loads the workflow and fill the name key if present
…stopherHX/33964-1
ChristopherHX
commented
May 5, 2025
models/actions/run_job_list.go
Outdated
Comment on lines
88
to
90
| if opts.OwnerID > 0 { | ||
| cond = cond.And(builder.Eq{"owner_id": opts.OwnerID}) | ||
| } |
There was a problem hiding this comment.
Previously unused, we need an inner join for this condition
models/actions/run_list.go
Outdated
Comment on lines
82
to
84
| if opts.OwnerID > 0 { | ||
| cond = cond.And(builder.Eq{"owner_id": opts.OwnerID}) | ||
| } |
There was a problem hiding this comment.
Previously unused, we need an inner join for this condition
| func (opts FindRunOptions) ToOrders() string { | ||
| return "`id` DESC" | ||
| return "`action_run`.`id` DESC" |
There was a problem hiding this comment.
inner join requires mentioning the table name
|
Verification update of keda k8s autoscaler (current gitea 1.24-rc works only with modified garm). Uses these apis
I could change the existing keda github-runner e2e test to pass on my end by manually running gitea and setting up the test repository without changing non test content. Maybe we could setup extended e2e test repositories to track external autoscaler compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
Fixes
runs/<run>part to align with apiRefactoring
TODO
Closes #23670
Closes #23796
Closes #24898
Replaces #28047 and is much more complete