Fix bug when generating repository #34149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yp05327
approved these changes
Apr 8, 2025
wxiaoguang
reviewed
Apr 8, 2025
| // 2 - check whether the repository with the same storage exists | ||
| isExist, err := gitrepo.IsRepositoryExist(ctx, generateRepo) | ||
| var isExist bool | ||
| isExist, err = gitrepo.IsRepositoryExist(ctx, generateRepo) |
There was a problem hiding this comment.
I do not think it is a bug
There was a problem hiding this comment.
line 103 will check if err is nil. Since the directory exist, we need to cleanupReposioty, so that this err should be the returned parameter but not a local variable.
There was a problem hiding this comment.
Show me why
func TestError(t *testing.T) {
f := func(t *testing.T) (err error) {
defer func() {
assert.ErrorContains(t, err, "error")
}()
val, err := 1, nil
_ = val
_ = err
assert.NoError(t, err)
return errors.New("error")
}
assert.ErrorContains(t, f(t), "error")
}
There was a problem hiding this comment.
OK. I see. The return will assign the error to the returned parameter err.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #31035