Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix http auth header parsing #34936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

Fix http auth header parsing #34936

merged 3 commits into from
Jul 3, 2025
+136 −78

Conversation

wxiaoguang
Copy link
Contributor

Using strings.EqualFold is wrong in many cases.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 2, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jul 3, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 3, 2025
hiifong
hiifong reviewed Jul 3, 2025
View reviewed changes
services/lfs/server.go Outdated
fallthrough
case "token":
return handleLFSToken(ctx, tokenSHA, target, mode)
token, ok := httpauth.ParseAuthorizationHeaderBearerToken(authorization)
Copy link
Member

@hiifong hiifong Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref：The Git LFS API uses HTTP Basic Authentication to authorize requests.

I'm not sure, would there be any other issues with us using token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That "basic" is not this "basic"

@wxiaoguang wxiaoguang enabled auto-merge (squash) July 3, 2025 02:36
@wxiaoguang wxiaoguang merged commit d6d643f into go-gitea:main Jul 3, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 3, 2025
@wxiaoguang wxiaoguang deleted the fix-string-equal branch July 3, 2025 03:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b963fdf 
* giteaofficial/main:
  Fix http auth header parsing (go-gitea#34936)
  Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928)
  Support getting last commit message using contents-ext API (go-gitea#34904)
  [skip ci] Updated translations via Crowdin
  Exclude devtest.ts from tailwindcss (go-gitea#34935)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot