Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

NorthRealm
Copy link
Contributor

@NorthRealm NorthRealm commented Aug 3, 2025

Fixed a nil pointer error.

Related #34337

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 3, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Aug 3, 2025
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional test :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 3, 2025
@techknowlogick techknowlogick added the backport/v1.24 This PR should be backported to Gitea 1.24 label Aug 3, 2025
@techknowlogick
Copy link
Member

@NorthRealm With the PRs you've submitted to the project I was wondering if you'd be interested in joining as a maintainer.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 3, 2025
@NorthRealm NorthRealm marked this pull request as draft August 4, 2025 08:00
@NorthRealm NorthRealm marked this pull request as ready for review August 4, 2025 08:09
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Aug 4, 2025
@NorthRealm
Copy link
Contributor Author

Hey @techknowlogick , thanks for interest. But currently I don't have enough time for it as I have other personal matters to attend to. Unrelated, just wanna let you know that bounties and my personal needs are initially incentive for me to raise PRs.

@NorthRealm
Copy link
Contributor Author

@techknowlogick I renamed the test file, as the deletion does not exist in 1.24. Automatic backport by the bot is going to fail.

@techknowlogick techknowlogick removed the backport/v1.24 This PR should be backported to Gitea 1.24 label Aug 5, 2025
@techknowlogick
Copy link
Member

@NorthRealm, no worries, that is completely understandable, and your contributions are appreciated, especially since you chose to do them with the time you do have available :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 5, 2025
@techknowlogick techknowlogick merged commit becd15f into go-gitea:main Aug 5, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 5, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 5, 2025
@NorthRealm NorthRealm deleted the patch-fix-action-api branch August 5, 2025 04:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 5, 2025
* giteaofficial/main:
  Fix Actions API (go-gitea#35204)
  Add webhook test for push event (go-gitea#34442)
  Remove unneeded if statements for `update repo` API  (go-gitea#35140)
  [skip ci] Updated translations via Crowdin
  Step down as maintainer (justusbunsi) (go-gitea#35212)
  Display pull request in merged commit view (go-gitea#35202)
  Step down as maintainer (pat-s) (go-gitea#35213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants