Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor smal code snippeds in models/issues/pull.go #35301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Refactor smal code snippeds in models/issues/pull.go #35301

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05d3643
make magic string an const
6543 Aug 18, 2025
ec37ffb
reformat sql to be more redable and use builder
6543 Aug 18, 2025
b5e2401
Merge branch 'main' into nits
6543 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make magic string an const
  • Loading branch information
@6543
6543 committed Aug 18, 2025
commit 05d36433aa6369c18c5f25db9eee05f00d85def9
4 changes: 3 additions & 1 deletion models/issues/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import (

var ErrMustCollaborator = util.NewPermissionDeniedErrorf("user must be a collaborator")

const reviewedBy = "Reviewed-by: "

// ErrPullRequestNotExist represents a "PullRequestNotExist" kind of error.
type ErrPullRequestNotExist struct {
ID int64
Expand Down Expand Up @@ -392,7 +394,7 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
} else if review.Reviewer == nil {
continue
}
if _, err := writer.Write([]byte("Reviewed-by: ")); err != nil {
if _, err := writer.Write([]byte(reviewedBy)); err != nil {
return err
}
if _, err := writer.Write([]byte(review.Reviewer.NewGitSig().String())); err != nil {
Expand Down