Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix review request webhook bug #35339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2025
Merged

Fix review request webhook bug #35339

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c52b92
Fix review request webhook bug
lunny Aug 23, 2025
00755d8
Add some comments
lunny Aug 23, 2025
8988396
Only trigger pull request open event to pass test
lunny Aug 23, 2025
499869b
Merge branch 'release/v1.24' into lunny/fix_review_request_webhook
lunny Aug 27, 2025
5898545
Merge branch 'release/v1.24' into lunny/fix_review_request_webhook
GiteaBot Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only trigger pull request open event to pass test
  • Loading branch information
@lunny
lunny committed Aug 23, 2025
commit 89883969e1d362a020718de94772153fe19cfc0b
2 changes: 1 addition & 1 deletion tests/integration/repo_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ func Test_WebhookPullRequest(t *testing.T) {
sessionUser4 := loginUser(t, "user4")

// ignore the possible review_requested event to keep the test deterministic
testAPICreateWebhookForRepo(t, sessionUser2, "user2", "repo1", provider.URL(), "pull_request")
testAPICreateWebhookForRepo(t, sessionUser2, "user2", "repo1", provider.URL(), "pull_request_only")

testAPICreateBranch(t, sessionUser2, "user2", "repo1", "master", "master2", http.StatusCreated)
// 2. trigger the webhook
Expand Down