go-gitea · silverwind · Sep 10, 2025 · Sep 1, 2025 · Sep 1, 2025 · Sep 5, 2025
diff --git a/routers/web/user/package.go b/routers/web/user/package.go
@@ -447,58 +447,65 @@ func PackageSettings(ctx *context.Context) {
 
 // PackageSettingsPost updates the package settings
 func PackageSettingsPost(ctx *context.Context) {
-	pd := ctx.Package.Descriptor
-
 	form := web.GetForm(ctx).(*forms.PackageSettingForm)
 	switch form.Action {
 	case "link":
-		if form.RepoName == "" { // remove the link
-			if err := packages_model.SetRepositoryLink(ctx, pd.Package.ID, 0); err != nil {
-				ctx.JSONError(ctx.Tr("packages.settings.unlink.error"))
-				return
-			}
-
-			ctx.Flash.Success(ctx.Tr("packages.settings.unlink.success"))
-			ctx.JSONRedirect("")
-			return
-		}
-
-		repo, err := repo_model.GetRepositoryByName(ctx, pd.Owner.ID, form.RepoName)
-		if err != nil {
-			if repo_model.IsErrRepoNotExist(err) {
-				ctx.JSONError(ctx.Tr("packages.settings.link.repo_not_found", form.RepoName))
-			} else {
-				ctx.ServerError("GetRepositoryByOwnerAndName", err)
-			}
-			return
-		}
+		packageSettingsPostActionLink(ctx, form)
+	case "delete":
+		packageSettingsPostActionDelete(ctx)
+	default:
+		ctx.NotFound(nil)
+	}
+}
 
-		if err := packages_model.SetRepositoryLink(ctx, pd.Package.ID, repo.ID); err != nil {
-			ctx.JSONError(ctx.Tr("packages.settings.link.error"))
+func packageSettingsPostActionLink(ctx *context.Context, form *forms.PackageSettingForm) {
+	pd := ctx.Package.Descriptor
+	if form.RepoName == "" { // remove the link
+		if err := packages_model.SetRepositoryLink(ctx, pd.Package.ID, 0); err != nil {
+			ctx.JSONError(ctx.Tr("packages.settings.unlink.error"))
 			return
 		}
 
-		ctx.Flash.Success(ctx.Tr("packages.settings.link.success"))
+		ctx.Flash.Success(ctx.Tr("packages.settings.unlink.success"))
 		ctx.JSONRedirect("")
 		return
-	case "delete":
-		err := packages_service.RemovePackageVersion(ctx, ctx.Doer, ctx.Package.Descriptor.Version)
-		if err != nil {
-			log.Error("Error deleting package: %v", err)
-			ctx.Flash.Error(ctx.Tr("packages.settings.delete.error"))
-		} else {
-			ctx.Flash.Success(ctx.Tr("packages.settings.delete.success"))
-		}
+	}
 
-		redirectURL := ctx.Package.Owner.HomeLink() + "/-/packages"
-		// redirect to the package if there are still versions available
-		if has, _ := packages_model.ExistVersion(ctx, &packages_model.PackageSearchOptions{PackageID: ctx.Package.Descriptor.Package.ID, IsInternal: optional.Some(false)}); has {
-			redirectURL = ctx.Package.Descriptor.PackageWebLink()
+	repo, err := repo_model.GetRepositoryByName(ctx, pd.Owner.ID, form.RepoName)
+	if err != nil {
+		if repo_model.IsErrRepoNotExist(err) {
+			ctx.JSONError(ctx.Tr("packages.settings.link.repo_not_found", form.RepoName))
+		} else {
+			ctx.ServerError("GetRepositoryByOwnerAndName", err)
 		}
+		return
+	}
 
-		ctx.Redirect(redirectURL)
+	if err := packages_model.SetRepositoryLink(ctx, pd.Package.ID, repo.ID); err != nil {
+		ctx.JSONError(ctx.Tr("packages.settings.link.error"))
 		return
 	}
+
+	ctx.Flash.Success(ctx.Tr("packages.settings.link.success"))
+	ctx.JSONRedirect("")
+}
+
+func packageSettingsPostActionDelete(ctx *context.Context) {
+	err := packages_service.RemovePackageVersion(ctx, ctx.Doer, ctx.Package.Descriptor.Version)
+	if err != nil {
+		log.Error("Error deleting package: %v", err)
+		ctx.Flash.Error(ctx.Tr("packages.settings.delete.error"))
+	} else {
+		ctx.Flash.Success(ctx.Tr("packages.settings.delete.success"))
+	}
+
+	redirectURL := ctx.Package.Owner.HomeLink() + "/-/packages"
+	// redirect to the package if there are still versions available
+	if has, _ := packages_model.ExistVersion(ctx, &packages_model.PackageSearchOptions{PackageID: ctx.Package.Descriptor.Package.ID, IsInternal: optional.Some(false)}); has {
+		redirectURL = ctx.Package.Descriptor.PackageWebLink()
+	}
+
+	ctx.Redirect(redirectURL)
 }
 
 // DownloadPackageFile serves the content of a package file

diff --git a/web_src/js/features/common-page.ts b/web_src/js/features/common-page.ts
@@ -4,6 +4,7 @@ import {fomanticQuery} from '../modules/fomantic/base.ts';
 import {queryElems} from '../utils/dom.ts';
 import {registerGlobalInitFunc, registerGlobalSelectorFunc} from '../modules/observer.ts';
 import {initAvatarUploaderWithCropper} from './comp/Cropper.ts';
+import {initCompSearchRepoBox} from './comp/SearchRepoBox.ts';
 
 const {appUrl} = window.config;
 
@@ -77,12 +78,10 @@ export function initGlobalDropdown() {
   });
 }
 
-export function initGlobalTabularMenu() {
+export function initGlobalComponent() {
   fomanticQuery('.ui.menu.tabular:not(.custom) .item').tab();
-}
-
-export function initGlobalAvatarUploader() {
   registerGlobalInitFunc('initAvatarUploader', initAvatarUploaderWithCropper);
+  registerGlobalInitFunc('initSearchRepoBox', initCompSearchRepoBox);
 }
 
 // for performance considerations, it only uses performant syntax

diff --git a/web_src/js/features/comp/SearchRepoBox.ts b/web_src/js/features/comp/SearchRepoBox.ts
@@ -3,11 +3,9 @@ import {htmlEscape} from '../../utils/html.ts';
 
 const {appSubUrl} = window.config;
 
-export function initCompSearchRepoBox(elSearchRepoBox: HTMLElement) {
-  const uid = elSearchRepoBox.getAttribute('data-uid');
-
-  const $searchRepoBox = fomanticQuery(elSearchRepoBox);
-  $searchRepoBox.search({
+export function initCompSearchRepoBox(el: HTMLElement) {
+  const uid = el.getAttribute('data-uid');
+  fomanticQuery(el).search({
     minCharacters: 2,
     apiSettings: {
       url: `${appSubUrl}/repo/search?q={query}&uid=${uid}`,

diff --git a/web_src/js/features/org-team.ts b/web_src/js/features/org-team.ts
@@ -1,6 +1,4 @@
 import {queryElems, toggleElem} from '../utils/dom.ts';
-import {initCompSearchRepoBox} from './comp/SearchRepoBox.ts';
-import {registerGlobalInitFunc} from '../modules/observer.ts';
 
 function initOrgTeamSettings() {
   // on the page "page-content organization new team"
@@ -16,5 +14,4 @@ function initOrgTeamSettings() {
 export function initOrgTeam() {
   if (!document.querySelector('.page-content.organization')) return;
   initOrgTeamSettings();
-  registerGlobalInitFunc('initSearchRepoBox', initCompSearchRepoBox);
 }
diff --git a/web_src/js/features/package-setting.ts b/web_src/js/features/package-setting.ts
diff --git a/web_src/js/index-domready.ts b/web_src/js/index-domready.ts
@@ -61,22 +61,20 @@ import {initColorPickers} from './features/colorpicker.ts';
 import {initAdminSelfCheck} from './features/admin/selfcheck.ts';
 import {initOAuth2SettingsDisableCheckbox} from './features/oauth2-settings.ts';
 import {initGlobalFetchAction} from './features/common-fetch-action.ts';
-import {initFootLanguageMenu, initGlobalAvatarUploader, initGlobalDropdown, initGlobalInput, initGlobalTabularMenu, initHeadNavbarContentToggle} from './features/common-page.ts';
+import {initFootLanguageMenu, initGlobalComponent, initGlobalDropdown, initGlobalInput, initHeadNavbarContentToggle} from './features/common-page.ts';
 import {initGlobalButtonClickOnEnter, initGlobalButtons, initGlobalDeleteButton} from './features/common-button.ts';
 import {initGlobalComboMarkdownEditor, initGlobalEnterQuickSubmit, initGlobalFormDirtyLeaveConfirm} from './features/common-form.ts';
 import {callInitFunctions} from './modules/init.ts';
 import {initRepoViewFileTree} from './features/repo-view-file-tree.ts';
-import {initPackageSettings} from './features/package-setting.ts';
 
 const initStartTime = performance.now();
 const initPerformanceTracer = callInitFunctions([
   initHtmx,
   initSubmitEventPolyfill,
   initGiteaFomantic,
 
-  initGlobalAvatarUploader,
+  initGlobalComponent,
   initGlobalDropdown,
-  initGlobalTabularMenu,
   initGlobalFetchAction,
   initGlobalTooltips,
   initGlobalButtonClickOnEnter,
@@ -164,8 +162,6 @@ const initPerformanceTracer = callInitFunctions([
 
   initOAuth2SettingsDisableCheckbox,
 
-  initPackageSettings,
-
   initRepoFileView,
 ]);