check user and repo for redirects when using git via SSH transport #35416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
previously requested changes
Sep 5, 2025
I see, much cleaner to implement it there. Moved the redirection handling there and also cleaned it up a bit |
|
Apart from missing tests for the SSH redirects, Git LFS over SSH tests now fail. Not sure why though... |
|
I implemented integration tests cloning renamed repos, CI tests are green |
lunny
approved these changes
Sep 7, 2025
hiifong
approved these changes
Sep 9, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 10, 2025
* giteaofficial/main: Fix a compare page 404 bug when the pull request disabled (go-gitea#35441) Use db.WithTx/WithTx2 instead of TxContext when possible (go-gitea#35428) [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#35444) check user and repo for redirects when using git via SSH transport (go-gitea#35416) Fix push commits comments when changing the pull request target branch (go-gitea#35386) Fix bug when issue disabled, pull request number in the commit message cannot be redirected (go-gitea#35420) [skip ci] Updated translations via Crowdin Update gofumpt, add go.mod ignore directive (go-gitea#35434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30565
When using git with a gitea hosted repository, the HTTP-Transport did honor the user and repository redirects, which are created when renaming a user or repo and also when transferring ownership of a repo to a different organization. This is extremely helpful, as repo URLs remain stable and do not have to be migrated on each client's worktree and other places, e.g. CI at once.
The SSH transport - which I favor - did not know of these redirections and I implemented a lookup during the
servcommand.Considerations
servcommand. I am not sure how gitea handles this and if this may lead to performance or concurrency problems. My manual tests do not indicate any, but I'd be glad if an experienced contributor could verify this.