Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

silverwind
Copy link
Member

Before:

Screenshot 2025-09-10 at 02 29 09

After:

Screenshot 2025-09-10 at 02 29 17

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2025
@lunny lunny added the type/bug label Sep 10, 2025
Copy link
Member

@kemzeb kemzeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(FYI not familiar with frontend work, but from reading the related Mozilla docs and the fact that .notifications-item is only used here, this looks fine to me)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2025
@silverwind
Copy link
Member Author

silverwind commented Sep 10, 2025

The default of overflow-wrap: normal is not good for cases where unbroken strings of text can appear. I think later we could try a global solution like

:root {
  overflow-wrap: anywhere
}

But I'm not sure yet if there would be unintended side-effects. Maybe it won't play well with text-overflow: elllipsis.

@silverwind silverwind enabled auto-merge (squash) September 10, 2025 13:03
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 10, 2025
@silverwind silverwind merged commit b76e69f into go-gitea:main Sep 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Sep 10, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 10, 2025
@lunny lunny modified the milestones: 1.26.0, 1.25.0 Sep 10, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 11, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix package link setting can only list limited repositories (go-gitea#35394)
  Vertically center date in file view latest commit (go-gitea#35456)
  Bump setup-node to v5 (go-gitea#35448)
  Extend comment treepath length (go-gitea#35389)
  Fix overflow in notifications list (go-gitea#35446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants