Initial work at implementing file methods #13

raff · 2018-08-29T01:28:18Z

Initial work at implementing file methods:

open (builtin) - for now only for read
File.read
File.write
File.close

codecov-io · 2018-08-29T01:30:45Z

Codecov Report

Merging #13 into master will increase coverage by 0.11%.
The diff coverage is 53.97%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   64.48%   64.59%   +0.11%     
==========================================
  Files          55       55              
  Lines        9821     9997     +176     
==========================================
+ Hits         6333     6458     +125     
- Misses       3039     3079      +40     
- Partials      449      460      +11

Impacted Files	Coverage Δ
py/args.go	`51.04% <0%> (-5.29%)`	⬇️
py/file.go	`50.79% <50%> (+50.79%)`	⬆️
builtin/builtin.go	`75.36% <76.74%> (+0.16%)`	⬆️
py/type.go	`49.59% <0%> (+0.32%)`	⬆️
py/int.go	`74.1% <0%> (+0.55%)`	⬆️
py/import.go	`17.67% <0%> (+1.1%)`	⬆️
py/internal.go	`32.01% <0%> (+1.97%)`	⬆️
py/method.go	`61.19% <0%> (+14.92%)`	⬆️
py/boundmethod.go	`57.14% <0%> (+57.14%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f14d0...4213ccf. Read the comment docs.

ncw · 2018-08-29T11:28:04Z

That looks very good :-)

Can you write some unit tests? These are written in python normally. I'd suggest you make a new file file.py.

Not sure exactly what to do about test files - that might need a bit of thought.

raff · 2018-08-29T17:41:35Z

Sure, will do!

raff · 2018-08-30T00:28:06Z

retest

raff · 2018-08-30T05:34:35Z

Do you know why the build is failing now ? In one place is complaining about gcc missing, and in the other it's failing compiling with Go 1.8 (but doesn't look it's in my code)

corona10 · 2018-08-30T06:07:44Z

@raff

Yes, it's appveyor.yml issue.

corona10 · 2018-08-30T06:37:13Z

@raff

You can pass the appveyor after PR #15 is merged.

corona10 · 2018-08-30T12:56:53Z

@raff
Can you rebase your PR?

sbinet

nice work!

I have a couple of comments and suggestions.

sbinet · 2018-08-30T13:07:37Z

builtin/builtin.go

+preferred way to open a file.  See file.__doc__ for further information.`
+
+func builtin_open(self, obj py.Object) (py.Object, error) {
+	if filename, ok := obj.(py.String); ok {


please always strive to limit indentation.
e.g.:

if filename, ok := obj.(py.String); ok { return py.OpenFile(string(filename)) } return nil, py.ExceptionNewf(py.TypeError, "coercing to Unicode: need string or buffer, %v found", obj.Type().Name)

sbinet · 2018-08-30T13:09:38Z

py/file.go

 type File os.File

+var FileType = NewType("file", `represents an open file`)


please document this exported variable.

actually.. do we need it to be exported, at this time?

Sorry, I copied what one of the other module did and tried to follow the same pattern. Happy to update to a more gopheric style if one is defined.

But I agree that in the current implementation there are a lot of objects that are exported and maybe don't really need to be.

sbinet · 2018-08-30T13:11:34Z

py/file.go

+}
+
+func (o *File) readResult(b []byte) (Object, error) {
+	var asBytes = false // default mode is "as string" - also move this in File struct


perhaps we could already do that as part of this CL ?

Ok, I have this part done (but I am still not done parsing the options for open() so it would still just work for string output).

Found some problems in the option parser that I am trying to decide if I want to ignore them for now or trying to get them fixed.

sbinet · 2018-08-30T13:11:59Z

py/file.go

+	var asBytes = false // default mode is "as string" - also move this in File struct
+
+	if b == nil {
+		if asBytes {


please prefer early returns to limit the needed amount of indentation.

sbinet · 2018-08-30T13:12:04Z

py/file.go

+
+	if asBytes {
+		return Bytes(b), nil
+	} else {


please prefer early returns to limit the needed amount of indentation.

@sbinet At some point we should be running golint which warns about this. However there is a lot of stuff to fix if we do decide to implement it!

raff · 2018-09-01T03:42:33Z

Finished up (for now) open file and rebased.

corona10 · 2018-09-01T04:59:17Z

Please squash into the single commit please

ncw · 2018-09-03T12:57:42Z

pytest/pytest.go

@@ -12,8 +12,10 @@ import (
 	"testing"

 	_ "github.com/go-python/gpython/builtin"
+	_ "github.com/go-python/gpython/sys"


This appears to duplicate the "sys" import?

ncw

I think that is looking good :-)

One small thing to change inline, then if you could squash and rebase on master that would be perfect - thanks

raff · 2018-09-05T01:52:06Z

After rebasing a million times (and maybe now I have finally figured out how to do it right) I think I am done!

corona10 · 2018-09-05T02:29:39Z

builtin/builtin.go

+	}
+
+	if newline != py.None {
+		return nil, py.ExceptionNewf(py.NotImplementedError, "errors not implemented yet")


Should it be like this?

return nil, py.ExceptionNewf(py.NotImplementedError, "newline not implemented yet")

good catch!

- open (builtin) - File.read - File.write - File.close

corona10 · 2018-09-05T08:34:59Z

LGTM,
IMHO, The result of code coverage issue is not important at this time.

Let's wait for @ncw review :)

ncw · 2018-09-05T09:11:11Z

Notes for future work...

It would be nice to improve the coverage of file.go. Ideally what we need are tests which exercise the expected functionality of file and increase the coverage. The coverage shows what needs to be done!

The args.go file doesn't have any tests which is a bit sad :-(

corona10 mentioned this pull request Aug 30, 2018

builtin: Update builtin_all and builtin_any for Python3 #15

Merged

sbinet requested a review from ncw August 30, 2018 13:05

sbinet reviewed Aug 30, 2018

View reviewed changes

raff force-pushed the master branch from 720f4d7 to e0d3653 Compare August 31, 2018 00:24

ncw reviewed Sep 3, 2018

View reviewed changes

ncw requested changes Sep 3, 2018

View reviewed changes

raff force-pushed the master branch from 99c7a5f to 9f92dd7 Compare September 4, 2018 23:30

corona10 requested changes Sep 5, 2018

View reviewed changes

Initial work at implementing file methods:

4213ccf

- open (builtin) - File.read - File.write - File.close

raff force-pushed the master branch from 9f92dd7 to 4213ccf Compare September 5, 2018 03:32

corona10 approved these changes Sep 5, 2018

View reviewed changes

ncw approved these changes Sep 5, 2018

View reviewed changes

sbinet approved these changes Sep 5, 2018

View reviewed changes

sbinet merged commit 6e7b5ec into go-python:master Sep 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial work at implementing file methods #13

Initial work at implementing file methods #13

raff commented Aug 29, 2018

codecov-io commented Aug 29, 2018 •

edited

Loading

ncw commented Aug 29, 2018

raff commented Aug 29, 2018

raff commented Aug 30, 2018

raff commented Aug 30, 2018

corona10 commented Aug 30, 2018

corona10 commented Aug 30, 2018

corona10 commented Aug 30, 2018

sbinet left a comment

sbinet Aug 30, 2018

sbinet Aug 30, 2018

raff Aug 31, 2018

sbinet Aug 30, 2018

raff Aug 31, 2018

sbinet Aug 30, 2018

sbinet Aug 30, 2018

ncw Aug 31, 2018

raff commented Sep 1, 2018

corona10 commented Sep 1, 2018

ncw Sep 3, 2018

raff Sep 4, 2018

ncw left a comment

raff commented Sep 5, 2018

corona10 Sep 5, 2018

raff Sep 5, 2018

corona10 commented Sep 5, 2018 •

edited

Loading

ncw commented Sep 5, 2018

		type File os.File

		var FileType = NewType("file", `represents an open file`)

Initial work at implementing file methods #13

Initial work at implementing file methods #13

Conversation

raff commented Aug 29, 2018

codecov-io commented Aug 29, 2018 • edited Loading

Codecov Report

ncw commented Aug 29, 2018

raff commented Aug 29, 2018

raff commented Aug 30, 2018

raff commented Aug 30, 2018

corona10 commented Aug 30, 2018

corona10 commented Aug 30, 2018

corona10 commented Aug 30, 2018

sbinet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raff commented Sep 1, 2018

corona10 commented Sep 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncw left a comment

Choose a reason for hiding this comment

raff commented Sep 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corona10 commented Sep 5, 2018 • edited Loading

ncw commented Sep 5, 2018

codecov-io commented Aug 29, 2018 •

edited

Loading

corona10 commented Sep 5, 2018 •

edited

Loading