Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix initialisation of function, staticmethod and classmethod __dict__ #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

ncw
Copy link
Collaborator

@ncw ncw commented Feb 16, 2019

Add test files for function, staticmethod and classmethod

Fixes #56

Add test files for function, staticmethod and classmethod

Fixes #56
@ncw ncw requested a review from corona10 February 16, 2019 13:16
@codecov-io
Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #57 into master will increase coverage by 1.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   66.44%   67.94%   +1.49%     
==========================================
  Files          59       59              
  Lines       10379    10378       -1     
==========================================
+ Hits         6896     7051     +155     
+ Misses       2990     2828     -162     
- Partials      493      499       +6
Impacted Files Coverage Δ
py/staticmethod.go 61.11% <100%> (+49.34%) ⬆️
py/classmethod.go 55% <100%> (+44.47%) ⬆️
py/function.go 96.09% <100%> (+70.13%) ⬆️
py/type.go 51.22% <0%> (+1.63%) ⬆️
py/tuple.go 31.13% <0%> (+6.6%) ⬆️
py/internal.go 40.86% <0%> (+7.21%) ⬆️
py/none.go 52.38% <0%> (+9.52%) ⬆️
py/dict.go 54.66% <0%> (+10.66%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9eac8...f26d5df. Read the comment docs.

Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@corona10 corona10 merged commit b05c0bd into master Feb 16, 2019
@corona10 corona10 deleted the fix-function branch February 16, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants