Thanks to visit codestin.com
Credit goes to github.com

Skip to content

builtin: Implement builtin_bin #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

corona10
Copy link
Collaborator

Implementation of builtin bin

@corona10 corona10 requested a review from ncw August 12, 2019 15:57
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.01%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   68.63%   68.65%   +0.01%     
==========================================
  Files          59       59              
  Lines       10512    10525      +13     
==========================================
+ Hits         7215     7226      +11     
- Misses       2789     2790       +1     
- Partials      508      509       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.67% <84.61%> (+0.11%) ⬆️
py/bigint.go 66.02% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff175c...f515870. Read the comment docs.

@corona10
Copy link
Collaborator Author

@ncw please take a look

Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :-)

LGTM

@corona10 corona10 merged commit 7bc4005 into go-python:master Aug 12, 2019
@corona10 corona10 deleted the builtin_bin branch August 12, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants